Closed Milly closed 3 months ago
[!IMPORTANT]
Auto Review Skipped
Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
The recent updates focus on transitioning import paths in Denops plugin for Vim and Neovim to a custom JavaScript registry (jsr
) scheme. This change streamlines module resolution and introduces specific versioning for external dependencies, enhancing the plugin's maintainability and compatibility with different environments.
File Path | Change Summary |
---|---|
denops/@denops-private/testutil/conf.ts |
Updated import paths for path-related functions to use jsr:@std/path@0.225.0 module specifier format. |
denops/@denops-private/testutil/conf_test.ts |
Transitioned assertEquals import to "jsr:@std/assert@0.225.1" for custom JavaScript registry URL. |
denops/@denops-private/util.ts |
Changed import paths to jsr scheme for denops_core and unknownutil with versions 6.0.6 and 3.18.0 respectively. |
denops/@denops-private/version.ts |
Altered import statements for path and semver modules to jsr: format with specific versions. |
denops/@denops-private/worker.ts |
Updated import paths for external modules to custom JavaScript resource (jsr ) scheme. |
plugin/denops.vim |
Specified Denops version requirements now demand Vim 9.1.0399 or Neovim 0.9.5. |
tests/denops/server_test.ts |
Introduced tests for denops#server#close() functionality using Deno for Vim and Neovim. |
🐇 Paths realigned, versions in sync,
Denops dances with a custom link.
Modules resolved, versions precise,
Code evolves, a solid device.
With each change, we leap and bound,
Ensuring stability all around.
🐇
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Attention: Patch coverage is 82.08955%
with 12 lines
in your changes are missing coverage. Please review.
Project coverage is 90.12%. Comparing base (
8041cd4
) to head (af70c82
).
Files | Patch % | Lines |
---|---|---|
denops/@denops-private/testutil/host.ts | 82.22% | 8 Missing :warning: |
denops/@denops-private/testutil/wait.ts | 81.81% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Deno 1.38.5 @ Windows + deno-denops-test 1.8.0 seems to have a non-stop issue. Maybe fixed in Deno 1.41.0.
Deno 1.38.5 @ Windows + deno-denops-test 1.8.0 seems to have a non-stop issue. Maybe fixed in Deno 1.41.0.
Then, let's merge it into v7-pre
branch. This is bug fix so I'd like to merge it into main
but if this cause test failure, it's not acceptable (and I think DenopsClosed
event bug is not critical for most of users)
I added test utilities and rewrote the tests. Unlike denops-test, it is now possible to RPC independently from denops running in Vim.
Actual
denops#server#close()
does NOT firesDenopsClosed
event.denops#server#close()
firesDenopsClosed
event.Expected
Both fires
DenopsClosed
event.Summary by CodeRabbit
New Features
worker.ts
to improve maintainability and flexibility.denops.vim
to align with Vim and Neovim updates.Improvements
version.ts
andconf.ts
for better module resolution and version control.util.ts
andconf_test.ts
.Bug Fixes
version.ts
to ensure correct module usage.conf.ts
andconf_test.ts
for consistent module resolution.