:bug: `denops#server#close()` should fires DenopsClosed event

Milly commented 3 months ago

Actual

vim: denops#server#close() does NOT fires DenopsClosed event.
nvim: denops#server#close() fires DenopsClosed event.

Expected

Both fires DenopsClosed event.

Summary by CodeRabbit

New Features
- Updated import paths for external modules in worker.ts to improve maintainability and flexibility.
- Adjusted version requirements in denops.vim to align with Vim and Neovim updates.
Improvements
- Enhanced import statements in version.ts and conf.ts for better module resolution and version control.
- Improved code readability and maintainability by updating import paths in util.ts and conf_test.ts.
Bug Fixes
- Resolved import statement issues in version.ts to ensure correct module usage.
- Fixed import paths in conf.ts and conf_test.ts for consistent module resolution.

coderabbitai[bot] commented 3 months ago

[!IMPORTANT]

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The recent updates focus on transitioning import paths in Denops plugin for Vim and Neovim to a custom JavaScript registry (jsr) scheme. This change streamlines module resolution and introduces specific versioning for external dependencies, enhancing the plugin's maintainability and compatibility with different environments.

Changes

File Path	Change Summary
`denops/@denops-private/testutil/conf.ts`	Updated import paths for path-related functions to use `jsr:@std/path@0.225.0` module specifier format.
`denops/@denops-private/testutil/conf_test.ts`	Transitioned `assertEquals` import to `"jsr:@std/assert@0.225.1"` for custom JavaScript registry URL.
`denops/@denops-private/util.ts`	Changed import paths to `jsr` scheme for `denops_core` and `unknownutil` with versions `6.0.6` and `3.18.0` respectively.
`denops/@denops-private/version.ts`	Altered import statements for path and semver modules to `jsr:` format with specific versions.
`denops/@denops-private/worker.ts`	Updated import paths for external modules to custom JavaScript resource (`jsr`) scheme.
`plugin/denops.vim`	Specified Denops version requirements now demand Vim 9.1.0399 or Neovim 0.9.5.
`tests/denops/server_test.ts`	Introduced tests for `denops#server#close()` functionality using Deno for Vim and Neovim.

🐇 Paths realigned, versions in sync,
Denops dances with a custom link.
Modules resolved, versions precise,
Code evolves, a solid device.
With each change, we leap and bound,
Ensuring stability all around.
🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 82.08955% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 90.12%. Comparing base (8041cd4) to head (af70c82).

Files	Patch %	Lines
denops/@denops-private/testutil/host.ts	82.22%	8 Missing :warning:
denops/@denops-private/testutil/wait.ts	81.81%	4 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## v7-pre #350 +/- ## ========================================== - Coverage 90.50% 90.12% -0.38% ========================================== Files 9 11 +2 Lines 632 699 +67 Branches 61 72 +11 ========================================== + Hits 572 630 +58 - Misses 60 69 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Milly commented 3 months ago

Deno 1.38.5 @ Windows + deno-denops-test 1.8.0 seems to have a non-stop issue. Maybe fixed in Deno 1.41.0.

lambdalisue commented 3 months ago

Deno 1.38.5 @ Windows + deno-denops-test 1.8.0 seems to have a non-stop issue. Maybe fixed in Deno 1.41.0.

Then, let's merge it into v7-pre branch. This is bug fix so I'd like to merge it into main but if this cause test failure, it's not acceptable (and I think DenopsClosed event bug is not critical for most of users)

Milly commented 3 months ago

I added test utilities and rewrote the tests. Unlike denops-test, it is now possible to RPC independently from denops running in Vim.

vim-denops / denops.vim