Closed Milly closed 3 months ago
[!IMPORTANT]
Review Skipped
Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
The updates across various files enhance testing utilities and configurations by refining types, improving return values, adding options, and updating commands for better testing processes.
File | Change Summary |
---|---|
deno.jsonc |
Modified test task to include LANG=C before deno test command. |
denops/.../testutil/host.ts |
Updated types and functions for better return values, added mode to options, and improved testHost . |
denops/.../testutil/wait.ts |
Added AssertionError import, updated wait function and options, enhanced timeout error handling. |
denops/.../testutil/with.ts |
Enhanced WithOptions with new properties, updated return types for withVim and withNeovim . |
denops/.../testutil/shared_server.ts |
Introduced functionality for starting a shared server for testing with options for verbosity and env. |
denops/.../testutil/shared_server_test.ts |
Added test cases for useSharedServer() , validating behavior in different scenarios. |
denops/.../testutil/wait_test.ts |
Introduced testing for the wait function, validating its behavior under various scenarios. |
tests/denops/plugin_test.ts |
Added test cases related to plugin/denops.vim behavior in starting local and shared servers. |
tests/denops/server_test.ts |
Refactored test cases for denops#server#status() and server behavior, covering various scenarios. |
In code we trust, improvements made, With each commit, progress displayed. Tests now run with language set, Ensuring bugs we won't forget. Enhanced our types, options refined, Better tools for peace of mind.
- 🐇 CodeRabbit
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
@coderabbitai review
Attention: Patch coverage is 99.21875%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 91.75%. Comparing base (
a69512d
) to head (6d3a7ef
).
Files | Patch % | Lines |
---|---|---|
denops/@denops-private/testutil/wait.ts | 97.22% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@coderabbitai review
Improve test typing. Add test function option comments. Add shared-server test helper. Show verbose logs use
-V1
insteadredir
. Error stack trace improved to easily understood. Addplugin/denops.vim
tests.Summary by CodeRabbit
New Features
vim
ornvim
) in test utilities.Improvements
Bug Fixes