coderabbitai[bot]
commented
3 months ago Walkthrough
The recent changes primarily involve replacing const with using for stub declarations across multiple test files to streamline stub management. Additionally, there are updates to imports, error handling, and timeout configurations to enhance test reliability and clarity.
Changes
| Files Affected | Change Summary |
|---|---|
denops/.../denops_test.ts, denops/.../host_test.ts, denops/.../service_test.ts |
Replaced const with using for stub declarations to simplify stub usage in test cases. |
denops/.../nvim_test.ts, denops/.../vim_test.ts |
Added new assertion functions and improved error handling in test cases. |
denops/.../service.ts |
Corrected a typo in an error message from "plguin" to "plugin". |
denops/.../testutil/conf.ts |
Added a timeout field to the Config interface and logic to parse timeout from environment. |
denops/.../testutil/shared_server.ts |
Increased the default timeout value from 5000 to 30,000. |
denops/.../testutil/shared_server_test.ts |
Updated import statement for the delay function to a specific version. |
denops/.../testutil/wait.ts |
Updated imports, introduced new constants for default timeout and interval, and modified assignments. |
tests/denops/server_test.ts |
Adjusted how status is retrieved within an execute call to handle potential state transitions. |
Possibly related issues
- vim-denops/denops.vim#354: The changes to
tests/denops/server_test.tsaddress the flakiness by adjusting how the status is retrieved and compared, which could resolve the issue of the test passing through states too quickly.
In code, we find our path anew, With
usingstubs, our tests break through. Timeouts extended, errors refined, In every line, precision defined. A rabbit's joy in changes made, In every test, success displayed. 🐇
[!TIP]
New Features and Improvements
## Review Settings Introduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments. ## AST-based Instructions CodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the [documentation](https://docs.coderabbit.ai/guides/review-instructions#ast-based). ## Community-driven AST-based Rules We are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the [ast-grep-essentials](https://github.com/coderabbitai/ast-grep-essentials) repository for more information. ## New Static Analysis Tools We are continually expanding our support for static analysis tools. We have added support for `biome`, `hadolint`, and `ast-grep`. Update the settings in your `.coderabbit.yaml` file or head over to the settings page to enable or disable the tools you want to use. ## Tone Settings Users can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples: - Mr. T: "You must talk like Mr. T in all your code reviews. I pity the fool who doesn't!" - Pirate: "Arr, matey! Ye must talk like a pirate in all yer code reviews. Yarrr!" - Snarky: "You must be snarky in all your code reviews. Snark, snark, snark!" ## Revamped Settings Page We have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to `.coderabbit.yaml` will be reflected in the settings page, and vice versa. ## Miscellaneous - Turn off free summarization: You can switch off free summarization of PRs opened by users not on a paid plan using the `enable_free_tier` setting. - Knowledge-base scope: You can now set the scope of the knowledge base to either the repository (`local`) or the organization (`global`) level using the `knowledge_base` setting. In addition, you can specify Jira project keys and Linear team keys to limit the knowledge base scope for those integrations. - High-level summary placement: You can now customize the location of the high-level summary in the PR description using the `high_level_summary_placeholder` setting (default `@coderabbitai summary`). - Revamped request changes workflow: You can now configure CodeRabbit to auto-approve or request changes on PRs based on the review feedback using the `request_changes_workflow` setting.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
codecov[bot]
Milly
usingforstub, insteadtry ... catch.DENOPS_TEST_TIMEOUTenvironment variable.Summary by CodeRabbit
New Features
timeoutfield to the configuration settings for better control over test durations.Improvements
Bug Fixes
Refactor
Tests