coderabbitai[bot]
commented
2 months ago Walkthrough
The recent update enhances the Denops plugin system by using a registered plugin list instead of discovering plugins dynamically. This change ensures that denops#cache#update() works correctly for plugins that do not use main.ts, improving reliability and consistency in plugin management.
Changes
| Files | Change Summary |
|---|---|
autoload/denops/cache.vim |
Replaced denops#_internal#plugin#collect() with denops#plugin#registered_files() |
autoload/denops/plugin.vim |
- Added s:registered_files dictionary- Updated denops#plugin#load to register files- Added denops#plugin#registered_files function |
Sequence Diagram(s)
sequenceDiagram
participant User
participant DenopsPlugin
participant Cache
User->>DenopsPlugin: Call `denops#plugin#load`
DenopsPlugin->>DenopsPlugin: Register files in `s:registered_files`
User->>Cache: Call `denops#cache#update()`
Cache->>DenopsPlugin: Call `denops#plugin#registered_files()`
DenopsPlugin->>Cache: Return registered files
Cache->>Cache: Update cache with registered filesAssessment against linked issues
| Objective | Addressed | Explanation |
|---|---|---|
Use registered plugins instead of discover in denops#cache#update() (#360) |
✅ |
Poem
In the land of code where plugins play,
A change has come to light the way.
No more searching, files in hand,
Denops now a better land.
Cache updated, smooth and bright,
Plugins load with pure delight.
🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
codecov[bot]
lambdalisue
Shougo
Fix #360
Summary by CodeRabbit
New Features
Improvements