Closed Milly closed 2 months ago
The changes primarily focus on enhancing type safety and the modularity of the denops
module. The CallbackId
type is now exported, aiding its use across other modules. The invoke
function has been refactored to use a new ServiceForInvoke
type and includes a serviceMethodArgs
object for argument validation, improving the function's reliability. Additionally, the Service
class in service.ts
implements a new interface, adding to its robustness and maintainability.
File | Change Summary |
---|---|
denops/.../host.ts |
Exported CallbackId , refactored invoke function using ServiceForInvoke and serviceMethodArgs . |
denops/.../service.ts |
Added imports for CallbackId and Service , updated Service class to implement HostService . |
In the code, a breeze so light,
CallbackId
now sees the light.Invoke
refactored, sleek and tight, Validations now are in sight. Denops grows strong, a joyful flight, For coders, a future bright! 🚀
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 92.37%. Comparing base (
1eabd14
) to head (120a0d9
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@coderabbitai review
Summary by CodeRabbit
Refactor
invoke
function to ensure consistent parameter handling.New Features
CallbackId
export for better clarity in callback handling.