:bug: Refactor `denops#plugin` module and fix `denops#cache#update()` to use registered plugins instead

lambdalisue commented 2 months ago

Close #360. Additionally denops#plugin#check_type also discover/find plugins as like denops#cache#update thus this PR fixed the behavior to use registered plugins instead.

Summary by CodeRabbit

New Features
- Improved plugin management with new states and event handlers for better reliability and efficiency.
Refactor
- Revised existing plugin management functions to support new state handling and callbacks.
- Enhanced plugin loading logic for more efficient operation.
Bug Fixes
- Addressed issues in plugin loading and reloading processes to prevent errors and improve performance.

coderabbitai[bot] commented 2 months ago

Walkthrough

Significant updates to the denops plugin management system include: adding plugin states, restructuring functions, and incorporating event handlers. Adjustments to denops#cache#update() enhance plugin registration, removing reliance on plugins with main.ts, and improving plugin loading reliability and efficiency.

Changes

File	Change Summary
`autoload/denops/_internal/plugin.vim`	Introduced plugin states, restructured management functions, and added event handlers.
`autoload/denops/cache.vim`	Converted variables to constants, introduced new constants, and optimized plugin list usage in `denops#cache#update()`.
`autoload/denops/plugin.vim`	Refactored plugin loading logic, updated state management, revised loading/waiting functions, and deprecated old functions.

Sequence Diagram(s)

sequenceDiagram
    participant Vim as Vim
    participant Denops as Denops Plugin System
    participant Plugin as Plugin

    Note over Vim, Denops: Plugin Loading Process
    Vim->>Denops: load(plugin_name, script)
    Denops->>Plugin: Set plugin state to LOADING
    Plugin->>Denops: Script execution result
    alt Successfully loaded
      Denops->>Plugin: Set state to LOADED
      Denops->>Vim: Notify success
    else Failed to load
      Denops->>Plugin: Set state to FAILED
      Denops->>Vim: Notify failure
    end

Assessment against linked issues

Objective (Issue #)	Addressed	Explanation
Use registered plugins instead of discover in `denops#cache#update()` (#360)	✅

Poem

In the world of code at night,
Plugins dance, a treat to the site,
States are new and handlers bloom,
Denops hums, dispelling gloom.
Cache now swift, no longer slow,
With these changes, watch it grow! 🌙🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.23%. Comparing base (6e14ad1) to head (2f30e6b).

:exclamation: Current head 2f30e6b differs from pull request most recent head c616af0

Please upload reports for the commit c616af0 to get more accurate results.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #367 +/- ## ======================================= Coverage 90.23% 90.23% ======================================= Files 9 9 Lines 676 676 Branches 64 64 ======================================= Hits 610 610 Misses 66 66 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Shougo commented 2 months ago

:call denops#cache#update()

[denops] Update cache of the following files. Call `denops#cache#update(#{reload: v:true})` to forcibly update.
[denops] /home/shougo/work/denops.vim/denops/@denops-private/mod.ts
[denops] /home/shougo/work/skkeleton/denops/skkeleton/main.ts
[denops] /home/shougo/work/ddc.vim/denops/ddc/app.ts
[denops] /home/shougo/work/ddu.vim/denops/ddu/app.ts
[denops] It tooks more than 5000 ms. Use Ctrl-C to cancel.
[denops] Deno cache is updated.

It is too slow. Why?

Shougo commented 2 months ago

~~And denops plugins are loaded but does not work when the branch is used.~~

Fixed.

Shougo commented 2 months ago

It works now.

lambdalisue commented 2 months ago

https://github.com/vim-denops/denops.vim/pull/367#issuecomment-2174613245

What do you mean "too"? I think it's common to take time for reloading all cache.

lambdalisue commented 2 months ago

Thanks for review & fix. I rebased to tidy commit history so rerequest a review in case @Shougo

Shougo commented 2 months ago

What do you mean "too"? I think it's common to take time for reloading all cache.

It is normal behavior?

Shougo commented 2 months ago

I have fixed for rabbit review.

lambdalisue commented 2 months ago

I have fixed for rabbit review.

I'm sorry but the rabbit review didn't make sense so we should ignore. I removed that commits and force pushed.

vim-denops / denops.vim