search

vim-denops / denops.vim

🐜 An ecosystem of Vim/Neovim which allows developers to write cross-platform plugins in Deno
https://vim-denops.github.io/denops-documentation/
MIT License
666 stars 33 forks source link

:+1: Forcibly show info/warn/error messages block to the user (RFC) #377

Closed lambdalisue closed 2 months ago

lambdalisue commented 2 months ago

Users may not realize that there are info/warn/error messages in the message history. This commit forcibly shows the messages to the user when the messages are posted with console.info/warn/error functions in Denops side.

With this change, for example Denops plugin loading issue is shown on the Vim start-up like below (tested with https://github.com/vim-denops/denops-issue358.vim)

https://github.com/vim-denops/denops.vim/assets/546312/f1c82de7-73f6-4546-9914-4a8fb1ec798d

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

Walkthrough

The recent changes introduce a new mechanism for handling delayed messages in the file autoload/denops/_internal/echo.vim. Constants and variables have been added to support this delayed messaging system. Echo functions have been refactored to utilize the new mechanism, ensuring messages can be managed more efficiently.

Changes

Files Change Summary
autoload/denops/_internal/echo.vim Added constants and variables for delayed messages; refactored echo functions.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Vim
    participant EchoMsg as s:echomsg
    participant EchoMsgDelay as s:echomsg_delay
    participant EchoMsgBatch as s:echomsg_batch

    User->>Vim: Input command triggering message
    Vim->>EchoMsg: Call s:echomsg(hl, msg)
    EchoMsg->>EchoMsgDelay: Check if delay is needed
    alt Delayed message
        EchoMsgDelay-->>EchoMsgBatch: Store message for batch processing
    else Immediate message
        EchoMsg->>Vim: Display message
    end

Poem

In the realm of Vim's swift text, A new message system to buffer the next. Delays are managed with grace and care, Echoes refined, as we’re happy to share. A batch of changes from Denops sublime, Making our coding dance in perfect rhyme.

  • 🐇 CodeRabbit
  (\(\ 
  ( -.-)
  o_(")(")

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.20%. Comparing base (b1a21ac) to head (28414d1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #377 +/- ## ======================================= Coverage 90.20% 90.20% ======================================= Files 9 9 Lines 684 684 Branches 67 67 ======================================= Hits 617 617 Misses 67 67 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.