coderabbitai[bot]
commented
2 months ago [!IMPORTANT]
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yamlfile in this repository. To trigger a single review, invoke the@coderabbitai reviewcommand.You can disable this status message by setting the
reviews.review_statustofalsein the CodeRabbit configuration file.
Walkthrough
This update enhances the Denops plugin by introducing robust error handling, improved channel management, and streamlined server behaviors. Key changes include adding error callbacks, refining connection retries, enhancing server start and stop mechanisms, and expanding test utilities. These modifications aim for better reliability, consistency in server operations, and improved test coverage.
Changes
| Files | Change Summary |
|---|---|
autoload/denops/_internal/job.vim |
Added error handling for job execution, adjusted callbacks to receive job objects. |
autoload/denops/_internal/server/chan.vim |
Replaced for loop with while for retries, added timeout for channel close, new force close functions. |
autoload/denops/_internal/server/proc.vim |
Simplified server startup, removed retry logic, updated autocmd event names. |
autoload/denops/server.vim |
Added new status constants and functions for server management, introduced new variables for server state management. |
denops/@denops-private/host.ts |
Added close() method to Service interface, updated invoke() function. |
denops/.../host/nvim_test.ts |
Updated function parameters to object destructuring, added close method to Service. |
denops/.../host/vim_test.ts |
Similar updates as nvim_test.ts, added close method to service. |
denops/.../host_test.ts |
Introduced close method in the service object, added corresponding test cases. |
denops/.../testutil/host.ts |
Added stdout and stderr parameters to HostFn and TestFn, updated related functions. |
denops/.../testutil/shared_server.ts |
Modified to handle stderr, added new channels for stdout and stderr. |
denops/.../shared_server_test.ts |
Added new assertions and conditions for verbose output handling, new tests for verbose scenarios. |
denops/.../shared_server_test_no_verbose.ts |
Introduced new file with test scenarios involving a brief delay. |
denops/.../shared_server_test_verbose_true.ts |
Introduced new file with test scenarios for verbose flag set to true. |
denops/.../with.ts |
Enhanced stream and process communication, updated command execution, improved error handling and cleanup. |
denops/.../worker.ts |
Updated command in connectHost to trigger DenopsSystemReady autocmd event. |
denops/.../worker_test.ts |
Updated doautocmd function parameter to DenopsSystemReady in multiple instances. |
doc/denops.txt |
Updated descriptions for restart thresholds, reconnect intervals, close timeout settings, and server functions. |
tests/.../plugin_test.ts |
Updated function definitions for object destructuring of the host parameter. |
tests/.../server_test.ts |
Improved test logic, asynchronous handling, error messages, and status transitions for server operations. |
Sequence Diagram(s)
sequenceDiagram
participant User
participant DenopsPlugin
participant Job
participant ServerChan
participant ServerProc
participant TestUtil
User->>DenopsPlugin: Initialize
DenopsPlugin->>ServerProc: Start server
ServerProc->>ServerChan: Establish connection
ServerChan->>DenopsPlugin: Connection established
User->>DenopsPlugin: Run Command
DenopsPlugin->>Job: Execute job
Job->>DenopsPlugin: Job result
User->>DenopsPlugin: Stop server
DenopsPlugin->>ServerProc: Shutdown server
ServerProc->>ServerChan: Close channels
ServerChan->>TestUtil: CleanupPoem
Amidst the code in Vim's delightful land,
Denops evolves with error handling grand.
Channels close with grace, no time to wait,
Jobs will run, never check too late.
Servers start and stop, reconnect anew,
In tests we trust, the bugs we now subdue.
Celebrate with hops, our journey never ends,
For each line of code, a rabbit-send depends.
(\(\
( -.-)
o_(")(") đ[!TIP]
Early access features: disabled
We are currently testing the following features in early access: - **OpenAI `gpt-4o` model for code reviews and chat**: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available. Note: - You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file. - Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide feedback and report issues.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
codecov[bot]
Milly
lambdalisue
denops-variable:g:denops#server#close_timeoutdenops#server#status():closingcloseddenops-function:denops#server#start()can now be called even when status isclosing. In that case, the status will becomestoppedand then restart asynchronously.denops#server#start()is changed to asynchronously.closing. In that case, the status will becomestoppedand then restart asynchronously.retry_threshold), it retries asynchronously (usesrestart_threshold).denops#server#stop()is changed to asynchronously.denops#server#restart()is changed to asynchronously.Summary by CodeRabbit
New Features
close()method to theServiceinterface for better resource management.stdoutandstderr.Bug Fixes
Refactor
forloops withwhileloops for better connection retries.Documentation
Tests