vim-denops / denops.vim

🐜 An ecosystem of Vim/Neovim which allows developers to write cross-platform plugins in Deno
https://vim-denops.github.io/denops-documentation/
MIT License
685 stars 36 forks source link

DO NOT MERGE: test CI check should be error #397

Closed Milly closed 3 months ago

Milly commented 3 months ago

DO NOT MERGE this PR! Testing CI check job should be error.

Related #396

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

[!WARNING]

Rate limit exceeded

@Milly has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 22 minutes and 41 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between ef3895bdf6f14a7b699f442ded17e6ff95c8ab77 and 37723a2ed0f99d769bfd78838ad2a7c8f7e70d98.

Walkthrough

This update involves incrementing the version numbers of essential software dependencies in the denops/supported_versions.json file. The adjustments ensure that the project stays aligned with the latest stable releases of Deno, Vim, and Neovim. These updates bring enhancements, bug fixes, and new features, contributing to improved functionality and performance.

Changes

File Change Summary
denops/supported_versions.json Updated Deno to 1.45.1, Vim to 9.1.0449, and Neovim to 0.10.1.

Poem

In the meadow, hop and play,
New versions brighten up the day! 🐇
Deno, Vim, and Neovim too,
With every leap, we start anew.
Bugs are chased, and features bloom,
Hooray for updates in the room! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
Milly commented 3 months ago

CI does not working

If we only changed the supported_versions.json file, the test CI did not run. This is not expected and 37723a2ed0f99d769bfd78838ad2a7c8f7e70d98 should be applied.

This is resolved in #398.

CI working

The test CI "check" job completed with an error as expected, so looks fine.

https://github.com/vim-denops/denops.vim/actions/runs/10227388183/job/28298772270?pr=397

Supported version inconsistency check 0s

Run deno task apply:supported-versions
  deno task apply:supported-versions
  git diff --exit-code
  shell: /usr/bin/bash --noprofile --norc -eo pipefail {0}

Task apply:supported-versions deno run --allow-read --allow-write .scripts/apply_supported_versions.ts
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index cf2ffeb..0654cf4 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -55,11 +55,11 @@ jobs:
           - macos-latest
           - ubuntu-latest
         deno_version:
-          - "1.45.0"
+          - "1.45.1"
           - "1.x"
         host_version:
-          - vim: "v9.1.0448"
-            nvim: "v0.10.0"
+          - vim: "v9.1.0449"
+            nvim: "v0.10.1"

     runs-on: ${{ matrix.runner }}

diff --git a/README.md b/README.md
index 593d7c3..8ccfc1f 100644
--- a/README.md
+++ b/README.md
@@ -3,9 +3,9 @@
 <strong>Denops</strong><br>
 <sup>An ecosystem for Vim/Neovim enabling developers to write plugins in Deno.</sup>

-[![Deno 1.45.0 or above]([https://img.shields.io/badge/Deno-Support%201.45.0-yellowgreen.svg?logo=deno)](https://github.com/denoland/deno/tree/v1.45.0](https://img.shields.io/badge/Deno-Support%201.45.0-yellowgreen.svg?logo=deno](https://github.com/denoland/deno/tree/v1.45.0)))
-[![Vim 9.1.0448 or above]([https://img.shields.io/badge/Vim-Support%209.1.0448-yellowgreen.svg?logo=vim)](https://github.com/vim/vim/tree/v9.1.0448](https://img.shields.io/badge/Vim-Support%209.1.0448-yellowgreen.svg?logo=vim](https://github.com/vim/vim/tree/v9.1.0448)))
-[![Neovim 0.10.0 or above]([https://img.shields.io/badge/Neovim-Support%200.10.0-yellowgreen.svg?logo=neovim&logoColor=white)](https://github.com/neovim/neovim/tree/v0.10.0](https://img.shields.io/badge/Neovim-Support%200.10.0-yellowgreen.svg?logo=neovim&logoColor=white](https://github.com/neovim/neovim/tree/v0.10.0)))
+[![Deno 1.45.1 or above]([https://img.shields.io/badge/Deno-Support%201.45.1-yellowgreen.svg?logo=deno)](https://github.com/denoland/deno/tree/v1.45.1](https://img.shields.io/badge/Deno-Support%201.45.1-yellowgreen.svg?logo=deno](https://github.com/denoland/deno/tree/v1.45.1)))
+[![Vim 9.1.0449 or above]([https://img.shields.io/badge/Vim-Support%209.1.0449-yellowgreen.svg?logo=vim)](https://github.com/vim/vim/tree/v9.1.0449](https://img.shields.io/badge/Vim-Support%209.1.0449-yellowgreen.svg?logo=vim](https://github.com/vim/vim/tree/v9.1.0449)))
+[![Neovim 0.10.1 or above]([https://img.shields.io/badge/Neovim-Support%200.10.1-yellowgreen.svg?logo=neovim&logoColor=white)](https://github.com/neovim/neovim/tree/v0.10.1](https://img.shields.io/badge/Neovim-Support%200.10.1-yellowgreen.svg?logo=neovim&logoColor=white](https://github.com/neovim/neovim/tree/v0.10.1)))

 [![MIT License]([https://img.shields.io/badge/license-MIT-blue.svg)](LICENSE](https://img.shields.io/badge/license-MIT-blue.svg](LICENSE)))
 [![test]([https://github.com/vim-denops/denops.vim/actions/workflows/test.yml/badge.svg)](https://github.com/vim-denops/denops.vim/actions/workflows/test.yml](https://github.com/vim-denops/denops.vim/actions/workflows/test.yml/badge.svg](https://github.com/vim-denops/denops.vim/actions/workflows/test.yml)))
diff --git a/plugin/denops.vim b/plugin/denops.vim
index 96e40ed..09a4c50 100644
--- a/plugin/denops.vim
+++ b/plugin/denops.vim
@@ -3,9 +3,9 @@ if exists('g:loaded_denops')
 endif
 let g:loaded_denops = 1

-if !get(g:, 'denops_disable_version_check') && !has('nvim-0.10.0') && !has('patch-9.1.0448)
+if !get(g:, 'denops_disable_version_check') && !has('nvim-0.10.1') && !has('patch-9.1.0449')
   echohl WarningMsg
-  echomsg '[denops] Denops requires Vim 9.1.0448 or Neovim 0.10.0. See ":h g:denops_disable_version_check" to disable this check.'
+  echomsg '[denops] Denops requires Vim 9.1.0449 or Neovim 0.10.1. See ":h g:denops_disable_version_check" to disable this check.'
   echohl None
   finish
 endif
Error: Process completed with exit code 1.