vim-erlang / vim-erlang-runtime

Erlang indentation and syntax for Vim
https://vim-erlang.github.io
101 stars 29 forks source link

Contributing to the erlang ftplugin #46

Closed slarwise closed 3 years ago

slarwise commented 3 years ago

Hi!

I was wondering if we can contribute to the erlang ftplugin through this repo. I think it would be nice to set some path and include-search related options, such as suffixesadd, include and define :)

hcs42 commented 3 years ago

Hi @slarwise. It's a good idea.

Hi @oscarh. Since you are the author of ftplugin/erlang.vim, and there is no maintainer noted, this means that you are the maintainer. In practice, this means that Bram Moolenar accepts updates to ftplugin/erlang.vim only from you.

Are you OK with making this repo the home of ftplugin/erlang.vim? It is already the home of syntax/erlang.vim and indent/erlang.vim. I periodically send the latest versions of these files to Bram for inclusion in the Vim repository.

Would you like to remain the maintainer of the script? (Review PRs, sending the e-mails to Bram?)

oscarh commented 3 years ago

Hi!

I really don't mind if you take over responsibility for the ftplugin/erlang.vim!

Unfortunately I haven't maintained my version of the repository for a long time. I also haven't been working with Erlang for a long time. This means my fork is probably / should be considered dead. I'm also not really a good candidate for reviewing pull requests.

hcs42 commented 3 years ago

@oscarh Thank you, I'm happy to take over the maintainership. Good luck with your non-Erlang work! :)

@slarwise I will add ftplugin/erlang.vim to this repo (in a few days at most), and you will be able to base your contributions on it.

slarwise commented 3 years ago

That's great, thank you :)

hcs42 commented 3 years ago

I added ftplugin/erlang.vim to this repository.

hcs42 commented 3 years ago

@slarwise The ftplugin/erlang.vim script in the current vim-erlang-runtime master is now in Vim: https://github.com/vim/vim/blob/master/runtime/ftplugin/erlang.vim

Thanks again!

slarwise commented 3 years ago

Awesome, that's great 😀