vim-jp / vim-cpp

c or cpp syntax files
147 stars 44 forks source link

Add more C++11 highlighting #10

Closed jwakely closed 11 years ago

jwakely commented 11 years ago
mattn commented 11 years ago

Thank you. It seems ok to me. @osyo-manga @usagi How do you think?

I prefer separate them by if !exists("cpp_no_cpp11").

usagi commented 11 years ago

I think about adbefa2 c8a6c82 bc54412 , there are no problems.

But, I have a one question for ecc8719 .

These two keywords are no problems:

But, the other keywords does not exist at least in the C++11 spec(ref: N3337).

These keywords are unspecified in the C++11. And, the spec 29.4 defined:

29.4 Lock-free property
#define ATOMIC_BOOL_LOCK_FREE unspecified
#define ATOMIC_CHAR_LOCK_FREE unspecified
#define ATOMIC_CHAR16_T_LOCK_FREE unspecified
#define ATOMIC_CHAR32_T_LOCK_FREE unspecified
#define ATOMIC_WCHAR_T_LOCK_FREE unspecified
#define ATOMIC_SHORT_LOCK_FREE unspecified
#define ATOMIC_INT_LOCK_FREE unspecified
#define ATOMIC_LONG_LOCK_FREE unspecified
#define ATOMIC_LLONG_LOCK_FREE unspecified
#define ATOMIC_POINTER_LOCK_FREE unspecified

And, these unspecified keywords has slightly different (ex.: "ATOMIC_BOOS_IS_LOCK_FREE" in the patch vs. "ATOMIC_BOOL_LOCK_FREE" in the spec.).

Do you know the source of these keywords in the patch?


I think good idea for the @mattn 's proposal to separate the files.

jwakely commented 11 years ago

Oops, those were just spelling mistakes while typing them in. I've pushed a corrected version.

I don't understand @mattn's suggestion.

usagi commented 11 years ago

@jwakely It's okay. Thanks for your fix and patches. @mattn I think these patches has no problems.

osyo-manga commented 11 years ago

Thank you patches :) I think it's okay.

mattn commented 11 years ago

@usagi @osyo-manga Thank to your reviews.

@jwakely Ok, I'll merge it

mattn commented 11 years ago

Thank you all. I merged it.

osyo-manga commented 11 years ago

Thank you @mattn :)