search

vim-jp / vim-cpp

c or cpp syntax files
145 stars 44 forks source link

Added C++14 binary literal highlight #31

Closed rhysd closed 8 years ago

rhysd commented 9 years ago

ISO/IEC 14882:2014 was issued at the beginning of this year. So we should start to improve vim-cpp to work well with C++14 code, I think.

As a first work, I added g:cpp_no_cpp14 variable check and a highlight for binary literal.

int main()
{
    0b01010100010;
    0b01010100010ll;
    0b01010100010ul;

    return 0;
}
mattn commented 9 years ago

LGTM but leave to others.

rhysd commented 9 years ago

@mattn

Thank you for your review.

Can anyone else review this PR?

mattn commented 9 years ago 
"\<0b[01]\+\(u\=l\{0,2}\|ll\=u\)\>"

でなくて大丈夫ですかね？

rhysd commented 9 years ago 
"\<0b[01]\+\(u\=l\{0,2}\|ll\=u\)\>"

でなくて大丈夫ですかね？

必要でした．ありがとうございます．今夜修正します．

rhysd commented 9 years ago

@mattn

修正しました！

rburny commented 8 years ago

Hello, could you please merge this pull request? Or alternatively, would it make sense to expand cppNumber definition to also cover digit separators?

rhysd commented 8 years ago

@rburny

Hi, could you review this PR? This PR is not merged yet because of lack of reviewer.

mattn commented 8 years ago

@rhysd :+1:

mattn commented 8 years ago

I'll send latest syntax/cpp.vim to vim-dev

rburny commented 8 years ago

Thanks! This one's already handled, but if you need review in future, feel free to ping me.

rhysd commented 8 years ago

@mattn

I'll send latest syntax/cpp.vim to vim-dev

:dog::+1:

@rburny

This one's already handled, but if you need review in future, feel free to ping me.

Thank you for your help! When I implement additional support, I may ping you.