search

vim-pandoc / vim-pandoc-syntax

pandoc markdown syntax, to be installed alongside vim-pandoc
MIT License
424 stars 61 forks source link

multiple smart punctuation fixes #312

Closed rwxrob closed 4 years ago

rwxrob commented 4 years ago

Still needs strike but otherwise quotes are golden in headers and elsewhere.

alerque commented 4 years ago

Thanks for taking the time to contribute this @rwxrob. The bulk of the vim stuff looks alright at first pass (although I haven't tested it in action yet), but I have a couple requests in regard to the Readme changes. If you can, I'd like to see the unrelated changes about plugin managers etc. in a separate commit (in case something goes haywire and we have to git bisect or revert). Are you familiar with rebasing? The easiest tool for that job by the way is git revise -c to split at existing commit by hunks.

rwxrob commented 4 years ago

Hope it's okay to just close this request and open a new one #313 with only the changes you suggest. I'm not (yet) acquainted with rebase and revise but will focus on it for next time.

I understand now your reason for not including images. That makes a lot of sense.

There is another bug with relation to ::: divs that I would like to work on later as well. Perhaps I'll submit the report first so we can track it. Thanks again.