search

vim-pandoc / vim-pandoc-syntax

pandoc markdown syntax, to be installed alongside vim-pandoc
MIT License
424 stars 61 forks source link

Dashes at end of line causing highlight problems #35

Closed fncll closed 10 years ago

fncll commented 10 years ago

Example:

Dashes at the end of a line--
causing highlighting problems

2nd line is highlighted for no apparent reason:

scratch3_md____tmp__-_vim_and_1__bash

blaenk commented 10 years ago

This looks like YAML front matter is being matched. Will confirm later.

On Jan 25, 2014, at 10:34 AM, fncll notifications@github.com wrote:

Example:

Dashes at the end of a line-- causing highlighting problems

2nd line is highlighted for no apparent reason:

[image: scratch3_md__tmp-_vim_and_1__bash]https://f.cloud.github.com/assets/1208889/2002360/427b5e8e-85ef-11e3-8fbe-1f9f571a5394.png

— Reply to this email directly or view it on GitHubhttps://github.com/vim-pandoc/vim-pandoc-syntax/issues/35 .

fmoralesc commented 10 years ago

There's two problems here.

First, the pandocTable rule matched, because it didn't check for the beginning of lines, which it now does.

Second, solarized adds highlighting rules that match our syntax rules, which it shouldn't (check :verbose hi pandocTable). pandocTable shouldn't be highlighted by default, for example. Worse still, it has no idea about grid, pipe and "simple" tables, so highlighting is wrong for those cases. It also adds unused rules, like "pandocEscapePair" (I'm not sure where that comes from, even). I would suggest deleting all pandoc references in colors/solarized.vim, since as they stand they are of no use/conflict ours. Of course, if you have no issue with that, you can keep things as is.