Don't highlight builtins used as kwarg.

[anntzer]

Don't highlight builtins immediately followed by an equal sign, as they are likely being used as keyword argument to a function, e.g. func(min=foo, max=bar). (Similarly to the case of attributes named using a builtin, it is unlikely that client code has the choice there anyways.)

[nfnty]

I think this is counterproductive, as the kwarg is overriding a builtin function and therefore should be highlighted differently.

[anntzer]

From the point of vue of client code (calling the function), there is no overriding happening (and, as mentioned above, client code doesn't really have a choice). Given that this is the most common case (you only define a function once, but it is (usually...) called multiple times), I think it should have priority.

At the function definition site, I agree that a different highlighting may be better. If one really wants to implement this, one could try to see whether you're in a function signature e.g. by checking if the next closing parenthesis is followed by a colon (modulo a return value annotation). However, in practice, the override is only a potential issue if the argument is used at least once (otherwise, it is harmless). In that case, the overridden builtin will at least appear highlighted as a builtin once in the body of the function.

[nfnty]

Trying to parse for definition vs call is going to be very complex and not worth it.

This is obviously subjective and therefore should be user configurable and disabled by default.

[anntzer]

Sounds OK to me. However it should probably be a disabling option, e.g. g:python_dont_highlight_builtin_as_kwarg. How would you like it to interact with highlight_all and highlight_builtins? (I don't have a strong preference but we may as well get it right from the beginning.)

[nfnty]

No, the option should be called g:python_highlight_builtin_funcs_kwarg and be enabled by default, regardless of other settings and only be used when g:python_highlight_builtin_funcs is enabled.

[nfnty]

I'll implement it.

[nfnty]

Thanks!