Add support for checkpatch.pl "CHECK" messages

vim-syntastic / syntastic

Syntax checking hacks for vim

Do What The F*ck You Want To Public License

11.3k stars 1.14k forks source link

Add support for checkpatch.pl "CHECK" messages #1828

Closed vivien closed 8 years ago

vivien commented 8 years ago

In addition to ERROR and WARNING messages, checkpatch.pl has a CHECK message type, e.g.:

CHECK: Comparison to NULL could be written "name"
#98: FILE: net/dsa/dsa.c:98:
+       if (name != NULL) {

Cc: @daniel-walker @d-k-c

lcd047 commented 8 years ago

No. Informational messages are deliberately left out. Besides, syntastic supports only errors and warnings.

vivien commented 8 years ago

I understand your concern about the message semantic, however checkpatch is a bit different. I don't know why they have a CHECK type, but the related messages are definitely syntax checking issues. Examples of such messages are:

"Alignment should match open parenthesis"
"Please use a blank line after function/struct/union/enum declarations"
"Please don't use multiple blank lines"
"Concatenated strings should use spaces between elements"
etc.

lcd047 commented 8 years ago

Those are style issues rather than syntax errors.