search

vim-syntastic / syntastic

Syntax checking hacks for vim
Do What The F*ck You Want To Public License
11.3k stars 1.14k forks source link

Fix govet errorformat #2349

Closed ohmystack closed 3 years ago

ohmystack commented 3 years ago

Adapt for the latest govet

ohmystack commented 3 years ago

I'm using go1.13.12, the go vet error message looks like this:

vet: ./main.go:8:2: use of package fmt not in selector

I find that the old errorformat will parse this filename as vet: ./main.go, which should be ./main.go, so I made this PR. I'm not familiar with the regex format used byerrorformat. If you have any ideas to optimize this PR, or have any docs about the format, please let me know. I'm glad to update my PR.

lcd047 commented 3 years ago

Ok, fixed in d97a664b.

ohmystack commented 3 years ago

@lcd047 It would better if you can guide me, the PR's author, to fix this PR, instead of creating a new PR without mention me. To be honest, I'm not happy with this.

Syntastic is a famous vim plugin. I have used it for years, and I really like it. When this govet problem came to me, I spent much time to locate the problem and figure out how to fix it because I also use the vim-go and I have to tell which plugin caused the problem.

I appreciate your hard work of maintaining this great plugin. I want to share my advice about the workflow of treating PRs. I hope that the PRs in this project can work in a way like other famous open-source projects, embracing and respecting the contributors.

lcd047 commented 3 years ago

@ohmystack You want to be mentioned for a 1-line patch to a checker that exists only for legacy reasons (you're supposed to use vim-go instead), in a Vim plugin that is essentially dead (it has been superseded by ALE). Sure, please let me know how I should handle this to give you the recognition you deserve for your invaluable contribution. Should I undo my patch so that you can post a new PR in your name?