vim-syntastic / syntastic

Syntax checking hacks for vim
Do What The F*ck You Want To Public License
11.3k stars 1.14k forks source link

Adds explicit buffer number to SyntasticStatuslineFlag. #2376

Closed SteveNeithardt closed 2 years ago

SteveNeithardt commented 2 years ago

When using splits in vim, it may happen that the statusline of an inactive window gets redrawn. In that case, the 'current()' buffer is no longer right. This fix finds the proper buffer number to use, by using the g:statusline_winid when it exists. In other cases, fallback to an empty current() call.

lcd047 commented 2 years ago

Nice detective work, but... no, sorry. Syntastic has been superseded by ALE, which takes advantage of Vim 8 features and is actively maintained. The main use for syntastic these days is for people who are (for whatever reasons) stuck with Vim 7. Sadly statusline_winid used in your patch has been introduced in Vim 8.1.1372. Thus sorry, but no.

SteveNeithardt commented 2 years ago

Oh ok. I'll admit to not checking version compatibility, my bad.

Good to know ALE exists. It could/should (?) be in the readme, so people that can upgrade to Vim 8 can also move on to ALE instead of staying here with Syntastic. I'll give it a go. Thank you for the review!