search

vim / colorschemes

colorschemes for Vim
279 stars 23 forks source link

TODO for inclusion of the remakes #132

Closed romainl closed 2 years ago

romainl commented 2 years ago
habamax commented 2 years ago

related #117

habamax commented 2 years ago

Should we create a PR first with all the colorschemes then add one by one codeowners, help topics changes and colors/README?

romainl commented 2 years ago

I think we can plan for a first PR with:

The rest of the documentation can wait a bit (if it needs to be fixed).

What about the sample_*.vim? Shall we add them to the PR or shall we keep them here?

habamax commented 2 years ago

I think we can plan for a first PR with:

* the colorschemes

* an updated README.txt

* an updated CODEOWNERS

The rest of the documentation can wait a bit (if it needs to be fixed).

Agree.

What about the sample_*.vim? Shall we add them to the PR or shall we keep them here?

We should keep it here.

romainl commented 2 years ago

@habamax @neutaaaaan https://github.com/romainl/vim/tree/feat/colorscheme-remakes is the branch I am going to use for the PR. For now, it has:

What should we add?

What should we remove?

What should we change?

habamax commented 2 years ago

What should we add?

Nothing so far.

What should we remove?

Nothing.

What should we change?

Documentation fixes maybe? Or we can postpone it?

Example:

:h colorsceheme
...
            You have two options for customizing a color scheme.
            For changing the appearance of specific colors, you
            can redefine a color name before loading the scheme.
            The desert scheme uses the khaki color for the cursor.
            To use a darker variation of the same color: >

                let v:colornames['khaki'] = '#bdb76b'
                colorscheme desert

this will not work, we don't use 'khaki' color.

habamax commented 2 years ago

Let's just create PR and update it if any changes would be requested by @chrisbra or @brammool

habamax commented 2 years ago

@chrisbra fyi, there are no settings for the colorschemes we remade -- no documentation is needed for them specifically.

romainl commented 2 years ago

That v:colornames feature, and its documentation, is even less relevant than when it was added now that all the bundled colorschemes only use hexadecimal notation. The only scenario where It might still be vaguely relevant is when using the default colorscheme in GUI.

I am not sure what to do about it. The verbiage kind of implies that v:colornames is the way to customize colors but even then it seems to only have effect in the GUI, no?

habamax commented 2 years ago

Legacies are merged in. Closing.