vim / colorschemes

colorschemes for Vim
288 stars 23 forks source link

QuickFixLine identical to Search or CursorLine in most colorschemes #133

Closed gdupras closed 2 years ago

gdupras commented 2 years ago

Some examples below in gVim, with :set cursorline and /link.

With blue.vim, QuickFixLine and Search are identical:

QuickFixLine_Search

With industry.vim, QuickFixLine and CursorLine are identical:

QuickFixLine_CursorLine

romainl commented 2 years ago

Thank you.

Using CursorLine is wrong because the two can be next to each other, as in your second screenshot, and using Search is also wrong because it makes it impossible to see a match.

@gdupras do you have a suggestion about how it should look?

romainl commented 2 years ago

I think I've got a good one for blue.vim:

Capture d’écran 2022-02-14 à 21 46 41

and possibly one for industry.vim, too:

Capture d’écran 2022-02-14 à 21 52 37

Using the fg of Title as bg for QuickFixLine.

gdupras commented 2 years ago

@romainl Your screenshots look good to me.

habamax commented 2 years ago

Search vs quickfixline

darkblue image

elflord: image

evening: image

koehler: image

pablo: image

ron: image

torte: image

Same QuickFixLine and CursorLine

Every other colorscheme except slate:

image

habamax commented 2 years ago

@romainl Check my PR (Note I didn't touch blue.vim and industry.vim)

Let me know if I should fix them too.

habamax commented 2 years ago

as a side note, probably sample_quickfix.vim should be added to the repo. Or it should be combined with existing samples.

habamax commented 2 years ago

And yeah, many of the OG have the same issue

habamax commented 2 years ago

@romainl industry is fixed too.

Now I am not so sure for blue. What I see on your screen is that QuickFixLine is magenta and IncSearch is darkmagenta.

Did you change IncSearch from magenta to darkmagenta?

PS, for me it doesn't look that good as it is too dark:

image

habamax commented 2 years ago

Well, for now I made it the same magenta:

image

Let me know if this has to be changed.

romainl commented 2 years ago

Thanks, I will check it out tonight.

romainl commented 2 years ago

@gdupras all the remakes that needed a fix are now fixed on master.

habamax commented 2 years ago

@gdupras let us know if QuickFixLine should be changed further.