QuickFixLine identical to Search or CursorLine in most colorschemes

[gdupras]

Some examples below in gVim, with :set cursorline and /link.

With blue.vim, QuickFixLine and Search are identical:

With industry.vim, QuickFixLine and CursorLine are identical:

[romainl]

Thank you.

• In a regular buffer, there is only one "current horizontal thing": the current line.
• In a quickfix buffer, there are two of those: the current line and the current quickfix item.

Using CursorLine is wrong because the two can be next to each other, as in your second screenshot, and using Search is also wrong because it makes it impossible to see a match.

@gdupras do you have a suggestion about how it should look?

[romainl]

I think I've got a good one for blue.vim:

and possibly one for industry.vim, too:

Using the fg of Title as bg for QuickFixLine.

[gdupras]

@romainl Your screenshots look good to me.

[habamax]

Search vs quickfixline

darkblue

elflord:

evening:

koehler:

pablo:

ron:

torte:

Same QuickFixLine and CursorLine

Every other colorscheme except slate:

[habamax]

@romainl Check my PR (Note I didn't touch blue.vim and industry.vim)

Let me know if I should fix them too.

[habamax]

as a side note, probably sample_quickfix.vim should be added to the repo. Or it should be combined with existing samples.

[habamax]

And yeah, many of the OG have the same issue

[habamax]

@romainl industry is fixed too.

Now I am not so sure for blue. What I see on your screen is that QuickFixLine is magenta and IncSearch is darkmagenta.

Did you change IncSearch from magenta to darkmagenta?

PS, for me it doesn't look that good as it is too dark:

[habamax]

Well, for now I made it the same magenta:

Let me know if this has to be changed.

[romainl]

Thanks, I will check it out tonight.

[romainl]

@gdupras all the remakes that needed a fix are now fixed on master.

[habamax]

@gdupras let us know if QuickFixLine should be changed further.