Issues with SpellBad, SpellCap, SpellLocal, SpellRare

[gdupras]

Those highlight groups are often:

• hard to read or unreadable,
• not visible,
• not distinct enough from one another.

Steps to reproduce the images below:

1. Create a file called en.utf-8.add that only contains:

   couleur/?

2. :mkspell en.utf-8.add
3. Create a file called spell_test.txt that contains:

Colour. colour color couleur kolour

4. Do

   gvim --clean -c "set spell spelllang=en_ca spellfile=en.utf-8.add" spell_test.txt

   This shows the Spell groups with the default colorscheme. The groups are, from left to right, SpellCap, SpellLocal, SpellRare, SpellBad.

5. :source colors/blue.vim (Or whatever colorscheme you want to check.)

default: Looks fine.

blue.vim: Spell groups are not visible.

darkblue.vim: Spell groups are not visible.

delek.vim: SpellLocal and SpellRare look the same.

desert.vim: SpellLocal and SpellRare are very similar.

elflord.vim: SpellLocal is unreadable.

evening.vim: Spell groups are not visible.

industry.vim: SpellLocal and SpellRare are very similar.

koehler.vim: SpellLocal is hard to read.

morning.vim: Looks fine.

murphy.vim: Looks fine.

pablo.vim: SpellLocal is hard to read.

peachpuff.vim: SpellCap and SpellRare are very similar.

ron.vim: SpellLocal is unreadable.

shine.vim: SpellLocal and SpellRare are very similar.

slate.vim: Looks fine.

torte.vim: SpellLocal is hard to read.

zellner.vim: SpellCap and SpellRare look the same.

I've only really tested GUI Vim but I think terminal Vim has similar issues.

[habamax]

@romainl is it time for a sample_spell.vim? :)

[habamax]

WIP

ron:

blue:

darkblue:

delek:

desert:

elflord:

evening:

industry:

pablo:

peachpuff:

shine:

torte:

zellner:

[romainl]

Thank you @gdupras for your detailed reports.

[romainl]

I'm not super comfortable with the background color, it may clash with other groups like incsearch or quickfixline.

Anyway, let's get on with that sample_spell.vim ;-).

@habamax sample_spell.vim just landed in fix/spell.

[habamax]

@romainl pls check

@gdupras could you pls also check fix/spell branch?

[habamax]

and indeed, nice catch, @gdupras, thank you!