windows cmd.exe and bold

[habamax]

Bold syntax elements in windows cmd.exe have "unexpected" background when t_Co=16 which is "default":

blue, for example

morning

(I have non-standard palette, thus colors are different, but still background issue is clearly visible)

@romainl should we remove all bolds from cterm?

e.g, for blue:

Comment              gray              none              g=bold

[habamax]

Or suggest everyone on cmd.exe to set t_Co=256 or set termguicolors?

[lifepillar]

How broken. Out of curiosity: can you double-check underline? Is it supported?

[habamax]

@lifepillar

[habamax]

and with t_Co=256

[lifepillar]

I don't think that giving up on text attributes because of that special case is a good idea. If the terminal is more capable than the default, definitely suggest to configure it so that it behaves as such. That seems to solve most issues. The fact that bold is not supported even with t_Co=256 should not be a big deal: no highlight group should rely solely on bold to differentiate things in an essential way.

[habamax]

The fact that bold is not supported even with t_Co=256 should not be a big deal: no highlight group should rely solely on bold to differentiate things in an essential way.

Blue is configured that way -- identifier and comment have the same color, comment is bold though.

[lifepillar]

Blue is configured that way -- identifier and comment have the same color, comment is bold though.

That should probably be fixed, then, unless it is ok for the two to have the same color (and attributes). Even modern terminals can be configured not to use boldface, and some users prefer to avoid bold fonts.

[habamax]

That should probably be fixed

@romainl ?