vim / colorschemes

colorschemes for Vim
279 stars 23 forks source link

fix: explicitly define TabLineSel colors #157

Closed habamax closed 2 years ago

habamax commented 2 years ago

Fixes #156

habamax commented 2 years ago

@craigmac fyi

craigmac commented 2 years ago

Wouldn’t it be prudent to replace all NONE with explicit colours where possible? It could avoid this happening again with some other odd edge case. As we’ve seen relying on NONE can’t be trusted.

lifepillar commented 2 years ago

Sometimes, NONE is necessary to make some highlight group “transparent”, such as Cursorline.

I think that the only problem is where all attributes are NONE, because IIRC in that case Vim reverts the highlight group to its default value (as in this issue). But don't take my word for granted.