Broken pablo scheme

[Aster89]

I think this might be well a dupe of #169 , but I'll let you decide, as it was suggested on vi.stackexchange that I did so.

Below is the commit just before 30ab04e16e1e9e6133590181197b3f8e70cb495e vs 8.2.4981

[habamax]

What are your settings for the pablo? It doesn't have any italics.

Also what is the terminal?

[habamax]

Regarding bold statement, we did it bold only for gui.

https://github.com/vim/colorschemes/blob/5812750e9dacc28cb7f53871654f2be2f500909e/colortemplate/pablo.colortemplate#L90

@romainl, I thing we should check the bold for the rest colorschemes too if we are to bring it back here

[habamax]

@Aster89 So as I answered on your SE question, old pablo is using color=3 which is yellow, which is different for almost anyone. So to unify term and gui we had to have a common ground.

For this xterm default palette was choosed. And yellow is xterm yellow which you can actually see on your second screenshot

[romainl]

@habamax agreed, too bad this comes up so late in the week-end.

@Aster89 you can grab the original pablo while we are working on this.

[Aster89]

What are your settings for the pablo? It doesn't have any italics.

I do have some styles that I've manually set via the following and simlar

au ColorScheme *
  \ hi Character                          ctermfg=magenta               |
  \ hi Comment                            ctermfg=grey     cterm=italic |
  \ hi SpecialChar                        ctermfg=magenta               |
  \ hi String                             ctermfg=red

so probably that's why you don't fully recognize pablo in my screenshots.

Also what is the terminal?

URxvt

[habamax]

Bold statement would be fixed, @Aster89

PS, +1 for au Colorscheme

[Aster89]

Bold statement would be fixed, @Aster89

You mean that the color change was intended but the bold removal was not?

PS, +1 for au Colorscheme

What you mean?

[habamax]

You mean that the color change was intended but the bold removal was not?

Yes, indeed. And yes, we missed the bold (I checked mostly on gVim, where bold is still present)

PS, +1 for au Colorscheme What you mean?

That is the proper way to adjust colorschemes, not many of vim users do this.

[gdupras]

Bold was removed because it was causing issues in cmd.exe on Windows, no?

See this issue and comment: https://github.com/vim/colorschemes/issues/150#issuecomment-1052279953

[habamax]

Ah, true! I was too fast to "fix" this issue. Thanks, @gdupras

[habamax]

So yes, now I remember that default cmd.exe has 16c where bold is unusable.

[habamax]

Bold was added