search

vim / colorschemes

colorschemes for Vim
276 stars 23 forks source link

StatusLine (and others?) missing bold in terminal #193

Closed sandwm closed 2 years ago

sandwm commented 2 years ago

In legacy elflord (and probably others) it was possible to determine the currently active vim window through the bold status line. In current elflord the status line of the active window just has a blue background that is a bit lighter than the others, which isn't as easy to see.

Legacy elflord (green is default terminal fg color here): statusline_old

Current elflord: statusline_upstream

Patched elflord: statusline_patched

For my current elflord version, seen in the third screenshot, I replaced g=bold with bold here: https://github.com/vim/colorschemes/blob/e0fa9ae954de5e09f32a54d58cdfb0719b26af50/colortemplate/elflord.colortemplate#L152

git grep 'g=[^ ]*bold' colortemplate/ gives a lot of results. I don't know what the reasoning is behind using bold only in the GUI in these cases. I also don't know where all of these highlight groups are used, but at least for this case, I would suggest using bold unconditionally, both for ease of use and staying closer to previous elflord versions.

habamax commented 2 years ago

@sandwm pls check latest master

sandwm commented 2 years ago

@habamax Thanks, new elflord looks good. 👍️

habamax commented 2 years ago

great!