vim / colorschemes

colorschemes for Vim
276 stars 23 forks source link

quiet light bg (gui/256) is quite different #200

Closed habamax closed 2 years ago

habamax commented 2 years ago

image

Not sure if this is terminal issue though.

there is no #d7d7d7 in 256c according to https://upload.wikimedia.org/wikipedia/commons/1/15/Xterm_256color_chart.svg

closest is 188 which is #dfdfdf and it is still in GUI looks different to my terminal

habamax commented 2 years ago

I made it use #dadada/253 for now, let me know if you have better ideas

image

habamax commented 2 years ago

I am not sure if this is windows, but 188 is broken

image

neutaaaaan commented 2 years ago

image

Alacritty is, as usual, the problem. Color 188 in xterm is #d7d7d7.

The difference between #d7d7d7 and #dadada is minute to say the least so I'm going to test-drive the slightly lighter background today. What I'm afraid of is in the context of an entire screen it might drown out elements I already had to tone down more than I was comfortable with, like colorcolumn.

habamax commented 2 years ago

Looks like it is not the alacritty, but the windows has the wrong 188 as in cmd.exe I can see the same pinkish colors.

I am okay with 188 as I don't use windows cmd.exe with vim but it is good to have somewhat similar colors across different environments.

I would also agree on what is correct xterm256 colors are.

Initially I have used https://www.ditig.com/256-colors-cheat-sheet (this what @neutaaaaan is using now) but I was persuaded by @romainl that https://upload.wikimedia.org/wikipedia/commons/1/15/Xterm_256color_chart.svg is more correct.

neutaaaaan commented 2 years ago

https://upload.wikimedia.org/wikipedia/commons/1/15/Xterm_256color_chart.svg

The 3rd block is wrong, every instance of df should be d7.

neutaaaaan commented 2 years ago

The ansi colors in both charts also seem wrong to me, what I'm seeing in xterm after a xrdb -remove is a lot lighter than that.

habamax commented 2 years ago

I think we should agree on what https://www.ditig.com/256-colors-cheat-sheet has.

Colortemplate uses the same:

https://github.com/lifepillar/vim-colortemplate/blob/848134abeab671a5671702237bd74eb49c411f88/autoload/colortemplate/colorspace.vim#L588-L612

habamax commented 2 years ago

So we should use the source where d7 is used instead of df.

neutaaaaan commented 2 years ago

For the sake of better documenting the issue, here's the original chart the .svg replaced about 10 years ago. This one has been verified against the xterm source code and it is correct.

So now that we've opened this can of worms, should we try getting the file on wikipedia fixed, as well as whatever is going on in alacritty and/or windows ?

habamax commented 2 years ago

I have reverted bg from #dadada to #d7d7d7 as was designed (other colors depend on it).

PS, looks like windows has issue with 188: image

habamax commented 2 years ago

Turned out only blue had a single color with df, others are ok. Blue is fixed.