review g:terminal_ansi_colors colors

[habamax]

Some of the colorschemes with non black/white backgrounds may have issues with terminal colors.

Here for example blue colorscheme where directories are invisible (in my bash, blue color is used to highlight directories, for others it might be used for different important things).

What can we do about it in general and with blue in particular?

For blue it might be a change of black to blue, and blue to black?

[habamax]

I would also add standard xterm colors for colorschemes where we presumably use it with incorrect values.

  xterm_black       #000000
  xterm_darkred     #cd0000
  xterm_darkgreen   #00cd00
  xterm_darkyellow  #cdcd00
  xterm_darkblue    #0000ee
  xterm_darkmagenta #cd00cd
  xterm_darkcyan    #00cdcd
  xterm_gray        #e5e5e5
  xterm_darkgray    #7f7f7f
  xterm_red         #ff0000
  xterm_green       #00ff00
  xterm_yellow      #ffff00
  xterm_blue        #5c5cff
  xterm_magenta     #ff00ff
  xterm_cyan        #00ffff
  xterm_white       #ffffff

[habamax]

I have put "proper" xterm colors into blue and now terminal looks more readable for me:

Color: x_black       #000000           16                black
Color: x_darkred     #cd0000           160               darkred
Color: x_darkgreen   #00cd00           40                darkgreen
Color: x_darkyellow  #cdcd00           184               darkyellow
Color: x_darkblue    #0000ee           21                darkblue
Color: x_darkmagenta #cd00cd           164               darkmagenta
Color: x_darkcyan    #00cdcd           44                darkcyan
Color: x_gray        #e5e5e5           254               gray
Color: x_darkgray    #7f7f7f           244               darkgray
Color: x_red         #ff0000           196               red
Color: x_green       #00ff00           46                green
Color: x_yellow      #ffff00           226               yellow
Color: x_blue        #5c5cff           63                blue
Color: x_magenta     #ff00ff           201               magenta
Color: x_cyan        #00ffff           51                cyan
Color: x_white       #ffffff           231               white

;;;  Terminal
Term colors: x_black    x_darkred x_darkgreen x_darkyellow x_darkblue x_darkmagenta x_darkcyan x_gray
Term colors: x_darkgray x_red     x_green     x_yellow     x_blue     x_magenta     x_cyan     x_white

with set tgc

[habamax]

PR is merged for blue.

For others, let people create separate issues.