search

vim / colorschemes

colorschemes for Vim
276 stars 23 forks source link

fix: better t_Co=0 detection #204

Closed habamax closed 2 years ago

habamax commented 2 years ago

@neutaaaaan pls check

Should close #202

habamax commented 2 years ago

I have checked with :terminal in Gvim, works ok, set t_Co=0 also works in fedora36 and wsl/fedora.

neutaaaaan commented 2 years ago

I can't find a way to break it. I'd merge, but seeing that lifepillar thinks it's inherently vim's fault, I'm going to let this linger a moment.

lifepillar commented 2 years ago

Even if it's recognized as a Vim bug, it's probably a good idea to make the color schemes robust against this issue. Before merging, can you check whether the t_Co test could be simplified, as I explained in the comment to the Colortemplate's pull request?

habamax commented 2 years ago

I will update colorschemes here first and if it would be robust -- will update PR against colortemplate

habamax commented 2 years ago

@neutaaaaan pls check

neutaaaaan commented 2 years ago

Looks good to me, can't break this either.

habamax commented 2 years ago

colortemplate PR is updated