Added/Changed/Removed: -> Normal

vim / colorschemes

colorschemes for Vim

274 stars 23 forks source link

Added/Changed/Removed: -> Normal #255

Closed neutaaaaan closed 6 months ago

neutaaaaan commented 6 months ago

Makes much more sense in the context of quiet

lifepillar commented 6 months ago

Are those new Vim highlight groups?

romainl commented 6 months ago

@lifepillar yes, see https://github.com/vim/vim/pull/13825.

Long story short:

in $VIMRUNTIME/syntax/diff.vim, diffAdded, diffChanged and diffRemoved were suboptimal,
the merged fix made things worse by linking them to DiffAdd, etc.,
I proposed a more subtle solution,
@chrisbra took my solution one step further by adding Added, etc.,
we are gradually fixing what needs to be fixed on our side.

lifepillar commented 6 months ago

Thanks, Colortemplate updated accordingly. Just a reminder that tools/check_colors.vim should probably also be updated to reflect those new syntax groups.