search

vim / colorschemes

colorschemes for Vim
289 stars 23 forks source link

feat: remake shine.vim #27

Closed habamax closed 4 years ago

habamax commented 4 years ago

Gui and 256 palette remake of shine.vim

Original syntax colors:

comment     #6c6c6c
constant    #ba8baf
identifier  #86c1b9
statement   #a1b56c
preproc     #af87af
type        #7ea06c
special     #ffd7dc
specialchar #6d6d6d
storage     #e77676

were updated to syntax colors:

comment     #6c6c6c 242
constant    #aa7b9f 139
identifier  #76b1a9 73
statement   #81a55c 107
preproc     #af87af 134
type        #7ea06c 108
special     #d75f87 168
specialchar #6d6d6d 242
storage     #d70000 160

Related to #12

habamax commented 4 years ago

image

image

image

PS, comments are non-italic (my custom override sniffed into screenshots)

habamax commented 4 years ago

image

romainl commented 4 years ago

FWIW, I've notified Yasuhiro Matsumoto, shine.vim's official maintainer, of this PR.

habamax commented 4 years ago

yep, I saw a new issue with a table.

habamax commented 4 years ago

So, what is the plan?

romainl commented 4 years ago

So, what is the plan?

  1. Wait for feedback from interested parties (maintainer, anyone).
  2. Handle feedback.
  3. Merge.
  4. Once we have enough colorschemes, a fixed color_check.vim, etc., get them into Vim.
habamax commented 4 years ago

Wait for feedback from interested parties (maintainer, anyone).

Do we have defined time period for that (of no feedback at all)?

romainl commented 4 years ago

My initial idea was to publicise the repo once we have enough colorschemes and organise a public vote.

As-is, I don't think we can realistically expect much public involvement for a while and open issues may be too messy for that public vote step.

I'll review this PR tonight (as well as polish mine) so that we can go further in a quick fashion.

Le lun. 21 sept. 2020 à 10:48, Maxim Kim notifications@github.com a écrit :

Wait for feedback from interested parties (maintainer, anyone).

Do we have defined time period for that (of no feedback at all)?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/vim/colorschemes/pull/27#issuecomment-695984865, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACUCD7DFTGBHDV5UQI4XYLSG4HM3ANCNFSM4RHBYTOA .

-- Romain Lafourcade

habamax commented 4 years ago

I can structure it (colortemplate source) the way you suggest to be uniform with all the rest-to-be-recreated colorschemes

romainl commented 4 years ago

Looks like we have our first remake.

habamax commented 4 years ago

Thx! Will pick another light colorscheme to remake.