Remove checks number 7 and 8 from check_colors.vim

lifepillar commented 4 years ago

Checks number 7 and 8 in check_colors.vim may be removed, now that https://github.com/vim/vim/issues/4405 has been fixed.

habamax commented 4 years ago

Hopefully @brammool will accept additional patch wrt to save/restore default links introduced by @adscriven -- then it would be even smoother: colorscheme whatever would be enough (no need to do additional syntax on)

habamax commented 2 years ago

I have "converted" the script to vim9script (there was no need to do it but anyway)

Old blue check_colors:

New blue:

romainl commented 2 years ago

@brammool, currently, the check_colors.vim script flags attempts to style debugPC and debugBreakpoint despite those highlight groups being documented as follows:

Colors                      *hl-debugPC* *hl-debugBreakpoint*

The color of the signs can be adjusted with these highlight groups:
- debugPC       the current position
- debugBreakpoint   a breakpoint

The defaults are, when 'background' is "light":
  hi debugPC term=reverse ctermbg=lightblue guibg=lightblue
  hi debugBreakpoint term=reverse ctermbg=red guibg=red

When 'background' is "dark":
  hi debugPC term=reverse ctermbg=darkblue guibg=darkblue
  hi debugBreakpoint term=reverse ctermbg=red guibg=red

Is there a technical reason for preventing their re-definition in colorschemes or can we skip this check?

habamax commented 2 years ago

cc @chrisbra

lifepillar commented 2 years ago

@romainl @brammool It was me who added that check. But now that https://github.com/vim/vim/issues/4405 is solved, I do not think there is any reason why they shouldn't appear in a color scheme. It is probably a good idea, instead, that they are always defined, at least for color schemes included in Vim.

vim / colorschemes

Remove checks number 7 and 8 from check_colors.vim #31