Closed rakus closed 5 years ago
Thanks. that are many changes. What's the thing about $API_TOKEN? That is not defined anywhere? I don't understand that part:
Cleanup .travis.yml, so deployment to GitHub is only done on master branch (just comment section on: in deploy:).
That is already commented and your last commit does already un-comment it? So what should be done before merging this?
I didn't even notice, there was an open issue #4 here. Sorry for that.
Regarding API_TOKEN: Authentication is needed for the deployment to GitHub. And there are two ways to do that. Either with a secure (aka encrypted) "api-key" in .travis.yml
. The other way is to add the key to the project configuration on travis as a protected environment variable.
If this merge request is approved for merging by you, I would add a last commit to:
In the current state I'm able to test deployment in my forked repo on my development branch.
ah okay, please go ahead :)
I realized a "problem" with the PR. During travis build it updates the Vim submodule. This changes have to be committed and must be pushed back to Github. I'm investigating.
I could continue in two directions:
ah okay. If possible, I would suggest to split up the PR.
Christian, I feared you would choose the second option :-). I would have done the same.
BTW: This a commit created by Travis
Closing this pull request, as it will be splitted into two separate PRs.
Rework build, support terminal Vim
cd
from inside VimChanges
Using AppImageKit V11
The script
scripts/appimage.sh
downloads a file namefunctions.sh
. This script uses v6 of the AppImageKit.Copied some lines from
functions.sh
toappimage.sh
and changed the URLs to use AppImageKit v11 (newest release). Important new feature:ARGV0
, see below.Startup
The
gvim.desktop
file is changed to call a script namedvim.startup.sh
. This script ...VIM
andVIMRUNTIME
(if not already set). With this Vim cancd
to other directories and still find its runtime files.ARGV0
set by AppImageKit. This variable contains the name the executable was started with. If the name starts withvim
, terminal Vim is started, else GVim is started. Now you can create a symlinkvim.appimage -> GVim*.AppImage
to get a terminal Vim.OWD
for this. This fixes #4.Building
.travis.yml
of Vim.make_vim.sh
is used to build Vim..travis.yml
)With this setup it is possible to build the AppImage with Travis cron jobs. So it is build daily and will automatically pick up the current Vim patch level, create a tag and a GitHub release.
E.g. Release v8.1.1211 was created by a Travis cron job.
Building via
make_vim.sh
is useful for local builds, alsoscripts/appimage.sh
uses a different build directory when not on Travis.The last point (API-Token) could be reverted. This way it was easier for me to test deployment to GitHub releases.
Testing
It is possible to copy the
GVim*.AppImage
file tovim/src/vim
and then startmake test
.This is currently not part of the Travis build, but could be added if wanted.
Before Merging this PR
Cleanup
.travis.yml
, so deployment to GitHub is only done on master branch (just comment sectionon:
indeploy:
).