vim / vim-appimage

AppImage for gVim
118 stars 18 forks source link

GVim lacks all GUI elements? #57

Closed ghost closed 10 months ago

ghost commented 10 months ago

When launching GVim-v9.0.1885.glibc2.29-x86_64.AppImage, it lacks all GUI elements, such as: the toolbar, menu, and other components.

GVim

chrisbra commented 10 months ago

I think this is a duplicate of #55

ghost commented 10 months ago

Not really, GVim-v9.0.1894.glibc2.29-x86_64.AppImage is now running in the terminal mode.

GVim

chrisbra commented 10 months ago

I thought this was about loading the menus, etc. Would be good if you would be clear from the beginning. Try running using -g

ghost commented 10 months ago

No, the error still exists when launching GVim-v9.0.1897.glibc2.29-x86_64.AppImage.

$ ./GVim-v9.0.1897.glibc2.29-x86_64.AppImage -g 

(gvim:20432): Gtk-WARNING **: <redacted>: Could not load a pixbuf from icon theme.
This may indicate that pixbuf loaders or the mime database could not be found.
**
Gtk:ERROR:../../../../gtk/gtkiconhelper.c:494:ensure_surface_for_gicon: assertion failed (error == NULL): Failed to load /usr/share/icons/Adwaita/16x16/status/image-missing.png: Unrecognized image file format (gdk-pixbuf-error-quark, 3)
Bail out! Gtk:ERROR:../../../../gtk/gtkiconhelper.c:494:ensure_surface_for_gicon: assertion failed (error == NULL): Failed to load /usr/share/icons/Adwaita/16x16/status/image-missing.png: Unrecognized image file format (gdk-pixbuf-error-quark, 3)
Vim: Caught deadly signal ABRT
Vim: Finished.
E852: The child process failed to start the GUI
Press ENTER or type command to continue

GVim

ghost commented 10 months ago

I suggest ensuring that every bug is thoroughly fixed before closing an issue on GitHub.

chrisbra commented 10 months ago

Those are different problems however.

1) was not loading the correct vim runtime files. This was fixed in 25c1c4abc5696222f242b9135406a214e2c0ae26 by setting the environment variable $VIMRUNTIME in the appimage 2) the gvim appimage was not started in graphical mode. This can be either done by adding the startup argument -g or by making sure, that the gvim symlink is executed. Which was what 45c81c17c82bde57d634fa5871b66e44039a8262

Both of those issues have been promptly fixed.

3) what you see now, seems to come by gvim trying to load different libraries that are available on your system vs. what it was compiled with. It may also matter what is in your configuration files. However, it seems to work fine, when starting with --clean. So I suggest to just use this. It looks like this issue here: https://github.com/AppImageCommunity/pkg2appimage/issues/536 which we have been struggling with before and the reason how to solve it was not quite clear.

Regarding this comment:

I suggest ensuring that every bug is thoroughly fixed before closing an issue on GitHub.

I cannot foresee what potential bug is coming up next, just because I fix a different one. Quite honestly, you haven't provided much information other than it doesn't work and I have promptly addressed the issues I saw already.

Anyway I don't really like this attitude however. Everything here is done during free time, nobody is paid for analyzing or fixing bugs as such, I find such comments not particular helpful in fixing remaining issue or even motivating me to spend my spare free time on this issue. So instead of demanding to have issues fixed how about you spend some time helping analyzing what is actually causing this issue and how to properly fix it?

ghost commented 10 months ago

Dear @chrisbra,

Anyway I don't really like this attitude however.

I want to clarify that my previous comment was not made to be judgmental or negative. I simply wanted to suggest that it would be better to wait for confirmation from the bug reporter before closing a bug. I apologize if my comment hurt your feelings.

Everything here is done during free time, nobody is paid for analyzing or fixing bugs as such, I find such comments not particular helpful in fixing remaining issue or even motivating me to spend my spare free time on this issue.

It was not my intention to diminish the hard work and dedication put into this project. I appreciate the effort you have already invested, and I will refrain from making such comments in the future.

ghost commented 10 months ago

I am running your GVim-v9.0.1897.glibc2.29-x86_64.AppImage build on my main Debian 12 system (with GNOME desktop installed). Despite starting it with --clean or removing all .vim files, the error persists.

I have attempted to compile vim/vim-appimage repository and run it on my main system, or tested both of builds on a clean virtual machine (with the gnome-core package installed); but I encountered the same error as the above.

Don't hesitate to inform me if you require any additional information.

chrisbra commented 10 months ago

thanks no problem.

We are basically now at #50 again. This errors seems to be hard to fix. It is not clear to me, how to properly fix this for gtk applications. I tried a few things (like copying the gdk-pixbuf libraries, set the GDK_PIXBUF_MODULE_FILE env variable, updated the mime-database, etc,) all did not help.

FWIW: I see the same issue on my debian bookworm installation, where it fails with --clean but when I disabling loading the graphical icons, it starts okay. On a different debian system, I see the exact opposite: it fails with this error when not using --clean but with --clean it opens up a nice little gui.

At this point, I am currently out of ideas and don't know how to properly fix it. As I said, we are now basically back at #50 (which I believe is essentially the same issue).

chrisbra commented 10 months ago

may be we need to use https://github.com/linuxdeploy/linuxdeploy-plugin-gtk

ghost commented 10 months ago

The bug has been well fixed in #60. Thank you for your hard work!

GVim

chrisbra commented 10 months ago

perfect thanks!