vimaec / vim-webgl-component

Vim React component based on vim-webgl-viewer
MIT License
2 stars 3 forks source link

Revert culling of "Autodesk" substring in data fields #243

Open mavimaec opened 1 year ago

mavimaec commented 1 year ago

TODO

The "Autodesk" substring is currently being culled when the product and version are presented in the data fields. For the purposes of reflecting the data "as-is" from the VIM file, we should not perform this culling.

SamuelAB-VIM commented 1 year ago

@mavimaec I want to minimize the mention of Autodesk where unnecessary I understand you would like me to leave the strings alone

If you judge the effort to reward to be inappropriate, you can revert this design change as it is not a showstopper

mavimaec commented 1 year ago

I want to minimize the mention of Autodesk where unnecessary

Could you expand on why you feel this way?

SamuelAB-VIM commented 1 year ago

I don't want to give them free marketing where we already mention Revit

mavimaec commented 1 year ago

I can empathize with your viewpoint. Nonetheless, from a technical standpoint, I suggest we revert the culling to ensure that the data displayed is as close as possible to the data contained in the VIM file.

SamuelAB-VIM commented 1 year ago

You have my blessings to reinstate the sanctity of the pure data 📿