search

vimalathithanr / TodoApp-Android

A todo app in android environment using Android studio for codepath.
0 stars 0 forks source link

Code Review #3

Open vimalathithanr opened 8 years ago

vimalathithanr commented 8 years ago

Hi Codepath,

Thanks for giving me an opportunity to attend Android - bootcamp. I have developed a sample todo application in android. Looking forward to hear your feedback. @codepathreview @codepath

Thanks, Vimalathithan

nesquena commented 8 years ago

Can you review the section in the prework about the readme for your project? In particular, check out this README template and be sure to include a GIF recorded with LiceCap. Please ping me back here once that's complete.

vimalathithanr commented 8 years ago

Nathan, thanks for your comment. My app is complete, Please review. @codepathreview @codepath

nesquena commented 8 years ago

Looks good, this exercise is intended in part to give you an introduction to the general rhythm of this course. The course is entirely project based with an app being assigned each week and then due the following week. Each project builds on the last to help each engineer to learn all practical Android development and best practices as quickly as possible. We also do a code review for each submitted project.

The next step is to continue working on extensions to your todo app and to schedule a short 10 minute phone conversation with us. Navigate to today's date and onward from there and choose a 15-minute slot. Let us know if none of those times work.

Once you select a slot, can you make sure to include best number to reach you at to the invite? Look forward to chatting soon!

Few pieces of specific feedback:

  1. Move the SQL code into the helper and out of the activity. In Android, we want to keep as much of the SQL specific CRUD code in the helper as possible. Activity should be as lean as possible.
  2. Can you take a look at this guide on code best practices to cleanup the source code?
  3. I'd like to see you improve the functionality of the Todo app in some way. For example, add priority, due date, or some other functional improvement on the todo app. Similarly with trying UI improvement.
vimalathithanr commented 8 years ago

Thanks for your review. I have made changes to UI and added priority functionality. Updated read me file for the same.

nesquena commented 8 years ago

Was good chatting with your earlier and glad to see you applied some of the feedback above and added priority. We'll be in touch again soon.