vimcolorschemes / vimcolorschemes

Find the best vim color schemes around
https://vimcolorschemes.com
GNU General Public License v3.0
815 stars 54 forks source link

bug: lackluster.nvim colorscheme not showing up #1000

Closed slugbyte closed 5 months ago

slugbyte commented 5 months ago

Describe the bug

the colorscheme https://github.com/slugbyte/lackluster.nvim is not showing up after a few weeks

The readme and description both have the words neovim and colorscheme

reobin commented 5 months ago

Hey @slugbyte ! will have a look this week as soon as I can. Thanks for the report!

slugbyte commented 5 months ago

thanks so much :)

reobin commented 5 months ago

Hello @slugbyte ! I had the chance to take a look at this. The colorscheme name seems to raise an issue with either the colorscheme or the preview generator on our side. While I investigate this, let me just lay here what I know and maybe it rings a bell for you:

The preview generator expects the name to be "lackluster" in this case, otherwise, it thinks the colorscheme failed to load and ignores it.

slugbyte commented 5 months ago

Thanks for looking into this!, that seems like the bug may be on my end I will see what I can do about that.

slugbyte commented 5 months ago

yep, I hadn't realized that i needed to set colors_name

I just pushed a patch that sets the names correctly, hopefully this will fix the issue.

sorry for the trouble!

reobin commented 5 months ago

Beautiful!

https://vimcolorschemes.com/slugbyte/lackluster.nvim

Thanks again for reaching out, have a good one!