bug: Found some errors on 5x version

[ViacheslavBurlaka]

have some errors

1. when try to change dynamically src to another or just navigate to another link, have this error: Uncaught TypeError: _a.destroy is not a function

2. some of my test hls stream videos have list of undefinedp playback quality

3. dbclick on fullscreen doesn't close fullscreen

version latest (5.0.19 + hls + react)

[mihar-22]

Hey @ViacheslavBurlaka!

1. I need to look into this.
2. If you could share the HLS streams so I can test it.
3. I've merged a PR that fixes fullscreen, releasing soon.

In regards to styling you can simply set the CSS variables on the player you'd like to change. The documentation has a section on it https://vimejs.com/getting-started/styling.

vm-player {
  /* CSS variables go here. */
}

You can find all CSS variables here: https://github.com/vime-js/vime/blob/master/core/src/themes/default.css

[ViacheslavBurlaka]

@mihar-22 thanks for your quick response!

2. 

of course, that link has undefinedp playback qualities: https://meta.vcdn.biz/9a7c35dfade6804f040929ab8b084efb_megogo/vod/hls/b/450_900_1350_1500_2000_5000/u_sid/0/o/363861/u_uid/573447295/u_vod/4/u_device/briz_ua/u_devicekey/_briz_ua_web/u_srvc/131/te/1611320031/a/11/type.amlst/playlist.m3u8

[mihar-22]

I think it might be because the playlist manifest doesn't specify a resolution on the streams. Here's an example: https://github.com/vime-js/media/blob/master/hls/index.m3u8.

#EXT-X-STREAM-INF:BANDWIDTH=800000,RESOLUTION=640x360"

[ViacheslavBurlaka]

Have a problem!

./node_modules/@vime/core/dist/custom-elements/index.js 319:15
Module parse failed: Unexpected token (319:15)
File was processed with these loaders:
 * ./node_modules/react-scripts/node_modules/babel-loader/lib/index.js
You may need an additional loader to handle the result of these loaders.
|     timeout = setTimeout(() => {
|       if (attempt === maxRetries) {
>         onFail?.();
|         return;
|       }

maybe someone know what the hell is?

it's happened when I've installed 5.0.0 or higher version in my create-react-app: react 17.0.1 "@vime/core": "^5.0.0", "@vime/react": "^5.0.0", "react-scripts": "4.0.1"

[mihar-22]

I have to somehow fix this, TypeScript suddenly isn't transpiling optional chaining ?. and Stencil doesn't let me change it. I'll look into it today.

[mihar-22]

Release is on the way right now to fix the ?. problem. CI should release it in 5 minutes.

[ViacheslavBurlaka]

another error, when click fullscreen and back Uncaught TypeError: _this$fullscreen2.destroy is not a function

[jbjhjm]

It's possible there is a regression in the current 5.0.31 builds. I'm experiencing the same untranspiled "?." issue again, see https://github.com/vime-js/vime/issues/209