vime-js / vime

Customizable, extensible, accessible and framework agnostic media player. Modern alternative to Video.js and Plyr. Supports HTML5, HLS, Dash, YouTube, Vimeo, Dailymotion...
https://vimejs.com
MIT License
2.75k stars 154 forks source link

fix(settings-menu): set pointer-events to none when settings menu is … #255

Closed yassinedoghri closed 2 years ago

yassinedoghri commented 2 years ago

Pull request type

Please check the type of change your PR introduces:

What is the current behavior?

When using vime as an audio player, the settings menu prevents clicking or interacting with other UI elements behind it when it is not visible.

Issue Number: N/A

What is the new behavior?

By setting pointer-events: none to the settings menu, elements behind it are now clickable.

Does this introduce a breaking change?

Other information

N/A

vercel[bot] commented 2 years ago

Someone is attempting to deploy a commit to the Vidstack Team on Vercel.

A member of the Team first needs to authorize it.

mihar-22 commented 2 years ago

Awesome! Thanks for the PR @yassinedoghri!