search

vime-js / vime

Customizable, extensible, accessible and framework agnostic media player. Modern alternative to Video.js and Plyr. Supports HTML5, HLS, Dash, YouTube, Vimeo, Dailymotion...
https://vimejs.com
MIT License
2.75k stars 154 forks source link

Update tsconfig.json #340

Closed g3r4n closed 1 year ago

g3r4n commented 1 year ago

Pull request type

What is the current behavior?

lot of warning in webpack build + dev exemple:

WARNING in ./node_modules/@vime/react/dist/esm/lib.jsx
Module Warning (from ./node_modules/react-scripts/node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from 'XXX/node_modules/@vime/react/src/lib.tsx' file: Error: ENOENT: no such file or directory, open 'XXX/node_modules/@vime/react/src/lib.tsx'

This is mainly due to the the fact that the src aren't shipped to npm. we either include the src or we don't ship any sourcemap

What is the new behavior?

Do not ship sourcemap

Does this introduce a breaking change?

Other information

vercel[bot] commented 1 year ago

@g3r4n is attempting to deploy a commit to the Vidstack Team on Vercel.

A member of the Team first needs to authorize it.