search

vime-js / vime

Customizable, extensible, accessible and framework agnostic media player. Modern alternative to Video.js and Plyr. Supports HTML5, HLS, Dash, YouTube, Vimeo, Dailymotion...
https://vimejs.com
MIT License
2.75k stars 154 forks source link

installation problem on react18 #367

Open pegahph opened 1 year ago

pegahph commented 1 year ago

Hi, I am using the package on a nextjs project and my react version is 18, I have installed @vime/react before and it was working fine but now that I need to reinstall my packages, this package gives me a dependency error and does not get install

*note: I don't have this problem with @vim/core it installs fine

Screenshot (156)

owujib commented 1 year ago

I am having the exact same problem, I am not sure if the solution I have is really cool. I resolved it with adding the ---legacy-peer-deps flag. or you could create a .npmrc file and add this to it legacy-peer-deps=true

jonybekov commented 1 year ago

@owujib legacy-peer-deps is just a temporary solution. Ideally, it should support React 18

owujib commented 1 year ago

@owujib legacy-peer-deps is just a temporary solution. Ideally, it should support React 18

Yeah I really wish it would be resolved