vime-js / vime

Customizable, extensible, accessible and framework agnostic media player. Modern alternative to Video.js and Plyr. Supports HTML5, HLS, Dash, YouTube, Vimeo, Dailymotion...
https://vimejs.com
MIT License
2.75k stars 154 forks source link

Warning when building an app using Vite 5 #377

Open fgordillo opened 9 months ago

fgordillo commented 9 months ago

I'm using @vime/vue-next in a project that uses Vite in order to build it. When I upgraded from vite 4.5 to vite 5.0.0 I started getting the following error many times on build (affecting different lines of the same file):

"/*#__PURE__*/"

in "node_modules/@vime/vue-next/dist/esm/components/index.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
node_modules/@vime/vue-next/dist/esm/components/index.js (99:21) A comment

I created a repository to facilitate the reproduction of the error. You can find it here

After some investigation, it seems this problem was faced by other plugins that are built using Vite (which uses Rollup) and they already came up with some solutions: https://github.com/intlify/vue-i18n-next/issues/1599

This is the first time I open an issue. I read the contributing guidelines and the code of conduct but I didn't find any template for what should be included in the issue. My apologies if there is one and I missed. Let me know if there is any further information needed.