vimeo / VIMVideoPlayer

Deprecated: Please use [PlayerKit]( https://github.com/vimeo/PlayerKit) instead.
MIT License
281 stars 63 forks source link

VIM-4503: Session time #60

Closed ghking closed 7 years ago

ghking commented 7 years ago

Ticket

https://vimean.atlassian.net/browse/VIM-4503

Ticket Summary

The current play logging events require session_time to be sent with the exit and play events. session_time is the total time the user has spent watching the video with the video actually playing. This ticket is for adding that parameter to those requests. Play logging spec here:

https://docs.google.com/document/d/1B4FPhSK_TECdygjgRhGLFx9vZUeg-9zePOqV5zD5RF0/edit#

This is a temporary implementation since we'll be overhauling our play logging with the new, unfinished spec that will be built by the API in the next few sprints.

Implementation Summary

Moving the TimeUpdateInterval constant to the header. This makes sense since as a user of this class, you can enable and disable time updates. It makes sense that you should be able to see at what interval these updates fire.

Also changed the name of this constant from TimeObserverInterval to TimeUpdateInterval to match the enableTimeUpdates and disableTimeUpdates function names.

Associated PR: https://github.vimeows.com/MobileApps/Vimeo-iOS/pull/951

How to Test

N/A

jasonhawkins commented 7 years ago

🏅GOLD🏅