vimeo / VIMVideoPlayer

Deprecated: Please use [PlayerKit]( https://github.com/vimeo/PlayerKit) instead.
MIT License
281 stars 63 forks source link

VIM-4419: DRM player error UI #62

Closed ghking closed 7 years ago

ghking commented 7 years ago

Ticket

https://vimean.atlassian.net/browse/VIM-4419

Ticket Summary

This implements UI states for DRM-specific errors in the player.

Implementation Summary

Since NSErrors from a failed AVAssetResourceLoadingRequest are propagated back to our video player as an underlying error, I added steps to select the appropriate error object in our status observer KVO.

It's kind of a bummer that an NSObject can come from three different places (Who is to say which one we want to forward on?) but this seems like a reasonable selection process.

Associated PR: https://github.vimeows.com/MobileApps/Vimeo-iOS/pull/960

How to Test

See associated PR.

alfiehanssen commented 7 years ago

This jawn assigned?

alfiehanssen commented 7 years ago

NICE DWR 💥