search

vimeo / graph-explorer

A graphite dashboard powered by structured metrics
http://vimeo.github.io/graph-explorer/
Apache License 2.0
1.06k stars 93 forks source link

Custom unit conversions #115

Closed offlinehacker closed 9 years ago

offlinehacker commented 10 years ago

What would be the best way to add custom unit conversions. I want to convert some financial data from unit to unit. I assume unit conversion plugin support should be integrated?

Dieterbe commented 10 years ago

normally you should be able to just use metrics with a custom unit. let's say you add a metric with unit=OfflineHack, you can now query for unit=MOfflineHack, unit=GiOfflineHack/h, etc

offlinehacker commented 10 years ago

I would like to covert for example usd to eur where i would be able to write custom conversion plugin. Support for that would make this app really awesome :) On May 26, 2014 6:05 PM, "Dieter Plaetinck" notifications@github.com wrote:

normally you should be able to just use metrics with a custom unit. let's say you add a metric with unit=OfflineHack, you can now query for unit=MOfflineHack, unit=GiOfflineHack/h, etc

— Reply to this email directly or view it on GitHubhttps://github.com/vimeo/graph-explorer/issues/115#issuecomment-44201032 .

Dieterbe commented 10 years ago

ah you want to convert between currencies. do you want to hardcode the currency conversion rate? what if it changes?

offlinehacker commented 10 years ago

That would be up to conversion plugin to retrieve conversion rate. On May 26, 2014 6:53 PM, "Dieter Plaetinck" notifications@github.com wrote:

ah you want to convert between currencies. do you want to hardcode the currency conversion rate? what if it changes?

— Reply to this email directly or view it on GitHubhttps://github.com/vimeo/graph-explorer/issues/115#issuecomment-44204183 .

Dieterbe commented 10 years ago

currently unit conversions are in the code base, not as plugins. if you want this, you can either code it in the app, or refactor it to have plugin unit conversions.

but you're the only one asking for this so doing it as plugins might be overkill, unless you find an easy way