search

vimeo / graph-explorer

A graphite dashboard powered by structured metrics
http://vimeo.github.io/graph-explorer/
Apache License 2.0
1.06k stars 93 forks source link

regexps fixed for collectd 5.x #119

Open underley opened 10 years ago

underley commented 10 years ago

Collectd 5.x graphite_writer plugin produces metrics like: collectd.host-1.memory.memory-buffered collectd.host-1.df-root.df_complex-reserved collectd.host-1.disk-dm-0.disk_octets.write Original regexps doesn't match such metrics.

underley commented 10 years ago
X-Trade commented 10 years ago

This works for us on our pre-deployment environment. What's stopping it from being merged?

Dieterbe commented 10 years ago

whoops, i somehow forgot about this one.

Dieterbe commented 10 years ago

hmm pretty sure we use collectd 5.4.0, our cpu metrics look like server.cpu.num.cpu.idle. same for interface, memory etc.

underley commented 10 years ago

collectd 5.1 from debian wheezy: collectd.server-name.cpu-1.cpu-user

X-Trade commented 10 years ago

Yeah, that's how it is for us too.

Looks to me like this plugin handles both though?

underley commented 10 years ago

exactly

Dieterbe commented 10 years ago

also using the phrase "fixes for collectd 5.x" is not really accurate, since apparantly it's only for older versions of 5.x (as they work for collectd 5.4)

Dieterbe commented 9 years ago

Ping? If the things I mentioned could be fixed, that would make a nice PR.

jsirex commented 9 years ago

@underley ,

<Plugin write_graphite>
  <Carbon>
    Host "10.6.128.209"
    Port 2003
    Prefix "staging.apache."
    EscapeCharacter "_"
    SeparateInstances true # <------- This one should be true
    StoreRates false
    AlwaysAppendDS false
  </Carbon>
</Plugin>