search

vimeo / graph-explorer

A graphite dashboard powered by structured metrics
http://vimeo.github.io/graph-explorer/
Apache License 2.0
1.06k stars 93 forks source link

Update network.py regex #120

Closed pblasquez closed 10 years ago

pblasquez commented 10 years ago

Added enrichment of collectd SNMP module input which has no 'collectd.' prefix.

Dieterbe commented 10 years ago

the network.py plugin is designed for diamond (i should probably rename it to diamond_network.py, cpu.py to diamond_cpu.py etc) have you looked at collectd.py ? it matches for network metrics in there.

pblasquez commented 10 years ago

No problem, I'll close this and open a new pull request. Question on prefixed vs. non-prefixed: Do you want to handle both cases in the collectd.py file or do you want to do it as collectd_prefixed.py, collectd_noprefix.py? I'll want to add both cases.

Dieterbe commented 10 years ago

well, if you look at collectd.py you'll see that we get the prefix value from the config, this is because different people have different prefixes, so that's how we support that. shouldn't this just work by setting collectd_prefix to empty string in your config?