search

vimeo / graph-explorer

A graphite dashboard powered by structured metrics
http://vimeo.github.io/graph-explorer/
Apache License 2.0
1.06k stars 93 forks source link

allow http-basic-auth accessing the graphite-server #21

Closed Finkregh closed 11 years ago

Dieterbe commented 11 years ago

nice commit. but timeserieswidget polls graphite too (for the metrics data), so it must also be made aware somehow.

wouldn't graphite_url = 'http://user:pass@graphitemachine (or whatever the syntax is) work for both Backend and timeserieswidget ?

Finkregh commented 11 years ago

i tried to use 'http://foo:bar@baz' as graphite_url and got a python-error...

the clientside polling happens in the browser which then sould present another auth-window to the user...

Dieterbe commented 11 years ago

which python error? presenting auth windows to the user isn't very clean, especially since we know the password in the config. we should somehow pass the auth data to timeserieswidget

Finkregh commented 11 years ago

which python error?

sorry, did not find the time to reproduce this as we switched to d3js :)

presenting auth windows to the user isn't very clean, especially since we know the password in the config. we should somehow pass the auth data to timeserieswidget

then if auth is enabled it might work to prefix the GET requests the client/js does with the user/pw we know from the config :)

feel free to close this if you want, as i do not need this function anymore :)