Closed adblockist closed 11 years ago
This patch is wrong, there is an error in graphite_url_metrics
can you file a PR that has 1 commit with a clear commit msg? i'll merge that
@zehome can you file a PR that has 1 commit with a clear commit msg? i'll merge that
fixed! thanks
Small issue but if you use urljoin, download_metrics_json would still work even if the user added a trailing slash to the end of the graphite_url
I had that in my URL and it failed in a non-obvious way.
Adding this made it work either way:
from urlparse import urljoin response = urllib2.urlopen(urljoin (self.config.graphite_url, "/metrics/index.json"))