search

vimeo / graph-explorer

A graphite dashboard powered by structured metrics
http://vimeo.github.io/graph-explorer/
Apache License 2.0
1.06k stars 93 forks source link

rename "avg/sum by" to "avg/sum across" #50

Closed Dieterbe closed 10 years ago

Dieterbe commented 10 years ago

since we aggregate across different values of a given tag, the terminology should IMHO be avg/sum across <tag> not avg/sum by <tag>.

thoughts?

Dieterbe commented 10 years ago

@zehome what do you think?

zehome commented 10 years ago

Seams good for me. Users are confused with avg over :)

Dieterbe commented 10 years ago

another reason is that the 'by' in group by means "make a group for each single value of the tag", as opposed to the "by" in avg|sum by which means not "make a sum|avg for each single value" but rather "for all different values", although it could be argued that's inherent to the word group (means singeling out) vs avg|sum which aggregate multiple values.

"avg over" and "avg across" might also be confusing.

and "across" is a bit long to type, compared to "by".

i feel like this solution wouldn't be ideal either.

Dieterbe commented 10 years ago

gonna leave it like it is for now..