@thepaul
when user requests unit=MiB/s or unit=TB or whatever, we should probably always process the data as B/s or B.
why? flot/timeserieswidget automatically shows markers on the Y axis with prefixes if needed. if it's showing B but you have tens of millions on them, it will show labels such 10M, 20M, etc.
say the user requests unit=kB and a value is 10M it would show as 10k kB, which seems pretty pointless and even confusing. I would rather have GE automatically show me 10M of unit B.
@thepaul when user requests unit=MiB/s or unit=TB or whatever, we should probably always process the data as B/s or B.
why? flot/timeserieswidget automatically shows markers on the Y axis with prefixes if needed. if it's showing B but you have tens of millions on them, it will show labels such 10M, 20M, etc. say the user requests unit=kB and a value is 10M it would show as 10k kB, which seems pretty pointless and even confusing. I would rather have GE automatically show me 10M of unit B.
timeserieswidget actually supports a
prefixesoption allowing us to toggle between SI and IEC, we actually already leverage this through perferences ( https://github.com/vimeo/graph-explorer/blob/master/preferences.py#L23)so what I think we should do when we request unit=MiB is set unit=B and suffixes=binary